feat: added snapshot_list and single view UI #249

sauraww · 2024-09-26T06:07:33Z

Added Snapshot UI List Page
Added Single Snapshot Page

crates/frontend/src/api.rs

mahatoankitkumar · 2024-09-26T06:18:47Z

crates/frontend/src/app.rs

+
+                            <Route 
+                              ssr=SsrMode::Async
+                              path="/admin/:tenant/snapshots"


Should we keep snapshots in the url or config-versions as we are using config-versions for the endpoint and the table as as well?

I think in UI it would become confusing if endpoints are config-versions and page shows snapshot.

mahatoankitkumar · 2024-09-26T06:18:54Z

crates/frontend/src/app.rs

+                            />  
+                            <Route 
+                              ssr=SsrMode::Async   
+                              path="/admin/:tenant/snapshots/:version"


mahatoankitkumar · 2024-09-26T06:20:11Z

crates/frontend/src/pages/snapshotconfig.rs

+
+                        view! {
+                            <Suspense fallback=move || view! { <p>"Loading..."</p> }.into_view()>
+                                {move || {


Can we have some kind of heading here, taking inspiration from the experiment page maybe?

Yeah , I will add it.

mahatoankitkumar · 2024-09-26T06:20:59Z

crates/frontend/src/types.rs

@@ -314,3 +314,19 @@ pub struct FetchTypeTemplateResponse {
    pub total_pages: i64,
    pub data: Vec<TypeTemplate>,
 }
+
+#[derive(Debug, Clone, Deserialize, Serialize)]
+pub struct SnapshotResponse {


You may have to change it similar to what i have done for the endpoint response type.

Use PaginatedResponse from superposition_types

We don't have superposition_types in frontend , Let's move all the common types in a seperate PR.
What do you suggest?

JamesGeorg · 2024-09-26T11:38:56Z

crates/frontend/src/api.rs

@@ -51,6 +52,24 @@ pub async fn fetch_default_config(
    Ok(response)
 }

+pub async fn get_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> {


Suggested change

pub async fn get_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> {

pub async fn fetch_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> {

Better to follow the same naming pattern across all functions

JamesGeorg · 2024-09-26T11:40:30Z

crates/frontend/src/api.rs

@@ -248,3 +267,24 @@ pub async fn fetch_types(
        .await
        .map_err(err_handler)
 }
+
+pub async fn get_config_by_version(


An already existing function fetch_config can be re-purposed to fetch config by version.

JamesGeorg · 2024-09-26T11:42:18Z

crates/frontend/src/pages/snapshotconfig.rs

This file can be named snapshot.rs

JamesGeorg · 2024-09-26T11:42:37Z

crates/frontend/src/pages/snapshotconfig.rs

+use leptos_router::use_params_map;
+
+#[component]
+pub fn SnapshotConfig() -> impl IntoView {


Suggested change

pub fn SnapshotConfig() -> impl IntoView {

pub fn snapshot() -> impl IntoView {

Please run leptosfmt, indetation is off in view macro

JamesGeorg · 2024-09-26T11:44:18Z

crates/frontend/src/pages/snapshotconfig.rs

+                            );
+
+                            view! {
+                                <Suspense fallback=move || view! { <p>"Loading..."</p> }.into_view()>


Use the loading skeleton for fallback in Suspense

JamesGeorg · 2024-09-26T11:47:05Z

crates/frontend/src/pages/snapshot_list.rs

+use crate::api::get_snapshots;
+
+#[derive(Serialize, Deserialize, Clone, Debug)]
+struct CombinedResource {


No need of CombinedResource here, we just have one resource to load i.e. snapshots.

JamesGeorg · 2024-09-26T11:51:21Z

crates/frontend/src/pages/snapshot_list.rs

+    });
+
+    let table_columns =
+        create_memo(move |_| snapshot_table_columns(tenant_rs.get_untracked()));


Suggested change

create_memo(move |_| snapshot_table_columns(tenant_rs.get_untracked()));

create_memo(move |_| snapshot_table_columns(tenant_rs.get()));

this has to be reactive to any changes made to tenant.

JamesGeorg · 2024-09-26T11:57:59Z

crates/frontend/src/pages/snapshot_list.rs

+    let combined_resource: Resource<String, CombinedResource> = create_blocking_resource(
+        move || tenant_rs.get(),
+        |current_tenant| async move {
+            match get_snapshots(current_tenant.to_string()).await {


We have a paginated API and still fetching all the snapshots at once. You can refer to experiment_list.rs to check how it can be done.

JamesGeorg · 2024-09-26T12:08:55Z

crates/frontend/src/pages/snapshot_list.rs

+                let href = format!("/admin/{}/snapshots/{}", tenant, id);
+                view! {
+                    <div>
+                        <A href=href class="btn-link">


The hyperlink can be added directly to the id value, that should be enough.

Datron · 2024-09-30T06:08:38Z

Target the main branch pleasse

mahatoankitkumar · 2024-10-03T06:57:48Z

crates/frontend/src/api.rs

+    let client = reqwest::Client::new();
+    let host = use_host_server();
+
+    let url = format!("{host}/config-versions");


Suggested change

let url = format!("{host}/config-versions");

let url = format!("{host}/config/versions");

mahatoankitkumar · 2024-10-03T06:59:52Z

crates/frontend/src/types.rs

@@ -314,3 +314,19 @@ pub struct FetchTypeTemplateResponse {
    pub total_pages: i64,
    pub data: Vec<TypeTemplate>,
 }
+
+#[derive(Debug, Clone, Deserialize, Serialize)]
+pub struct SnapshotResponse {


Use PaginatedResponse from superposition_types

sauraww requested a review from a team as a code owner September 26, 2024 06:07

mahatoankitkumar requested changes Sep 26, 2024

View reviewed changes

sauraww force-pushed the feat/snapshot-list-ui branch 4 times, most recently from 3e1cb92 to 7bf8df3 Compare September 26, 2024 11:24

JamesGeorg requested changes Sep 26, 2024

View reviewed changes

mahatoankitkumar force-pushed the feat/get-snapshots branch from 6594ee1 to 25eb4c6 Compare September 27, 2024 05:50

sauraww force-pushed the feat/snapshot-list-ui branch 12 times, most recently from 8759b15 to 07b5d8f Compare September 29, 2024 15:37

Datron requested review from mahatoankitkumar and JamesGeorg September 30, 2024 06:08

Datron closed this Sep 30, 2024

Datron reopened this Sep 30, 2024

mahatoankitkumar force-pushed the feat/get-snapshots branch 3 times, most recently from f9d45c0 to 1a03a27 Compare September 30, 2024 11:35

Base automatically changed from feat/get-snapshots to main September 30, 2024 12:00

sauraww force-pushed the feat/snapshot-list-ui branch from 07b5d8f to 094fd01 Compare October 1, 2024 17:20

sauraww force-pushed the feat/snapshot-list-ui branch 6 times, most recently from f81d64d to 46c1b9c Compare October 1, 2024 19:24

mahatoankitkumar requested changes Oct 3, 2024

View reviewed changes

sauraww force-pushed the feat/snapshot-list-ui branch 5 times, most recently from 3164cad to ffa2b37 Compare October 7, 2024 12:44

feat: added snapshot UI

3281556

sauraww force-pushed the feat/snapshot-list-ui branch from ffa2b37 to 3281556 Compare October 9, 2024 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added snapshot_list and single view UI #249

feat: added snapshot_list and single view UI #249

sauraww commented Sep 26, 2024

mahatoankitkumar Sep 26, 2024

sauraww Sep 26, 2024

mahatoankitkumar Sep 26, 2024

mahatoankitkumar Sep 26, 2024

sauraww Sep 26, 2024

mahatoankitkumar Sep 26, 2024

mahatoankitkumar Oct 3, 2024

sauraww Oct 7, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

JamesGeorg Sep 26, 2024

Datron commented Sep 30, 2024

mahatoankitkumar Oct 3, 2024

mahatoankitkumar Oct 3, 2024

	pub async fn get_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> {
	pub async fn fetch_snapshots(tenant: String) -> Result<SnapshotResponse, ServerFnError> {

	pub fn SnapshotConfig() -> impl IntoView {
	pub fn snapshot() -> impl IntoView {

	create_memo(move \|_\| snapshot_table_columns(tenant_rs.get_untracked()));
	create_memo(move \|_\| snapshot_table_columns(tenant_rs.get()));

	let url = format!("{host}/config-versions");
	let url = format!("{host}/config/versions");

feat: added snapshot_list and single view UI #249

Are you sure you want to change the base?

feat: added snapshot_list and single view UI #249

Conversation

sauraww commented Sep 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Datron commented Sep 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment