feat: JsonLogic algebraic representation #297
Conversation
ShubhranshuSanjeev
force-pushed
the
feat/json-logic-repr
branch
5 times, most recently
from
9886f4d to
96705d5
Compare
crates/frontend/src/logic.rs
Outdated
| Value(serde_json::Value), | ||
| Dimension(serde_json::Value), |
There was a problem hiding this comment.
dimension will always be a string, can it be typed like that?
There was a problem hiding this comment.
Yes it will be a string, I am just keeping things simple, I am getting it as a json { "var": <dimension_name> }, so I am keeping the same structure, and not taking the dimension name out of the var.
There was a problem hiding this comment.
Would it be better to take it out? Since "var" is useless in parsing later on
| @@ -81,14 +81,18 @@ pub enum SchemaType { | |||
| impl SchemaType { | |||
| pub fn default_value(&self) -> Value { | |||
| match self { | |||
| SchemaType::Multiple(_) => json!(""), | |||
| SchemaType::Single(JsonSchemaType::String) => json!(""), | |||
| SchemaType::Multiple(_) => Value::String(String::default()), | |||
There was a problem hiding this comment.
Can we write a comment on how to use SchemaType::Mulitple with some documentation at the type location?
There was a problem hiding this comment.
So JsonSchema allows to give a list of type. type in schema can be either a string or a array of string example [boolean, integer]. The array corresponds to SchemaType::Multiple.
There was a problem hiding this comment.
@ShubhranshuSanjeev this definitely needs documentation. I assumed this represented a way to define multiple schemas for a type
| if !enum_variants.is_empty() { | ||
| return InputType::Select(enum_variants); | ||
| } |
There was a problem hiding this comment.
shouldn't the else case for this be an error to the user
that they need to define at least one enum to allow editing to it
| SchemaType::Single(JsonSchemaType::Integer) => InputType::Integer, | ||
| SchemaType::Single(JsonSchemaType::Boolean) => InputType::Toggle, | ||
| SchemaType::Single(JsonSchemaType::Null) => InputType::Disabled, | ||
| _ => InputType::Text, |
There was a problem hiding this comment.
can we be explicit here, to make it better visible, so that if we are assigning a wrong input to a SchemaType it becomes more obvious
for example, here I suppose we should have provided Monaco input for Object and Array, right ?
| SchemaType::Single(JsonSchemaType::Number) => json!(0), | ||
| SchemaType::Single(JsonSchemaType::Integer) => json!(0), |
There was a problem hiding this comment.
| SchemaType::Single(JsonSchemaType::Number) => json!(0), | |
| SchemaType::Single(JsonSchemaType::Integer) => json!(0), | |
| SchemaType::Single(JsonSchemaType::Number) => Value::Number(Number::from(0)), | |
| SchemaType::Single(JsonSchemaType::Integer) => Value::Number(Number::from(0)), |
ShubhranshuSanjeev
force-pushed
the
feat/json-logic-repr
branch
2 times, most recently
from
4411923 to
6fc31a5
Compare
ShubhranshuSanjeev
force-pushed
the
feat/json-logic-repr
branch
from
6fc31a5 to
313dd0f
Compare
Problem
No concrete type representation for JsonLogic in Rust, leading to clumsy parsing and custom logic to generate context conditions.
Solution
This PR introduces types such as:
which aims towards representing JsonLogic correctly in an algebraic fashion.
Along with the type, behaviors such as generating context JsonLogic, conversion from JsonLogic to these types are also added in this PR.
Alongside, generating forms from JsonLogic is handled in this PR, additionally logic to parse based on operators all defined at one place, for ease of use.