Skip to content

Commit

Permalink
fix(makefile): disable weird c++20 template-id-cdtor warning
Browse files Browse the repository at this point in the history
we use -std=c++17
./v8/include/v8-local-handle.h:401:30: error: template-id not allowed for constructor in C++20
  • Loading branch information
lostrepo committed Jun 24, 2024
1 parent 8dab870 commit cd0cee8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ LINK=clang++
LARGS=-rdynamic -pthread -static-libstdc++
CCARGS=-std=c++17 -c -fno-omit-frame-pointer -fno-rtti -fno-exceptions
CARGS=-c -fno-omit-frame-pointer
WARN=-Werror -Wpedantic -Wall -Wextra -Wno-unused-parameter
WARN=-Werror -Wpedantic -Wall -Wextra -Wno-unused-parameter -Wno-template-id-cdtor
OPT=-O3
VERSION=0.0.17-pre
V8_VERSION=12.4
Expand Down Expand Up @@ -79,7 +79,7 @@ else
$(CC) ${CARGS} builtins.S -o builtins.o
endif

${RUNTIME}.o: ## compile runtime into an object file
${RUNTIME}.o: ## compile runtime into an object file
$(CXX) ${CCARGS} ${OPT} -DRUNTIME='"${RUNTIME}"' -DVERSION='"${VERSION}"' ${V8_FLAGS} -I./v8 -I./v8/include ${WARN} ${RUNTIME}.cc

${RUNTIME}: v8/include v8/libv8_monolith.a main.js ${BINDINGS} builtins.o main.o ${RUNTIME}.o ## link the runtime for linux/macos
Expand Down

0 comments on commit cd0cee8

Please sign in to comment.