Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsw-000: disable nuxt build and preview temporarily #101

Merged
merged 1 commit into from
Apr 5, 2024
Merged

dsw-000: disable nuxt build and preview temporarily #101

merged 1 commit into from
Apr 5, 2024

Conversation

jamieomaguire
Copy link
Contributor

Temporarily disabling the build and preview steps for Nuxt to avoid confusion whilst we investigate the Lit SSR errors.

fernandofranca
fernandofranca approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need the exit 0, though it also doesn't do any harm. 👍

fernandofranca
fernandofranca approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need the exit 0, though it also doesn't do any harm. 👍

@jamieomaguire jamieomaguire merged commit 8a1040c into main Apr 5, 2024
6 checks passed
@jamieomaguire jamieomaguire deleted the dsw-000-disable-nuxt-build-preview branch April 5, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggerzz siggerzz siggerzz approved these changes

@fernandofranca fernandofranca fernandofranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamieomaguire @fernandofranca @siggerzz