feat: DSW-1597: Update input version and update form integrations #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieomaguire
changed the title
jamieomaguire
changed the title
ashleynolan
reviewed
Apr 23, 2024
|
|
||
| const handleEmailChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| setEmail(event.target.value); | ||
| const handleEmailInput = (event: InputEvent) => { |
There was a problem hiding this comment.
I'm not sure if this would be clearer or not (or even work like I think it may), but seeing the repetition made me think of doing something like this:
const handleInput = (handlerFn) => {
return handlerFn((event.target as HTMLInputElement).value);
}
const handleEmailInput = handleInput(setEmail);
const handleUrlInput = handleInput(setUrl);
const handleTelInput = handleInput(setTel);
const handlePasswordInput = handleInput(setPassword);There was a problem hiding this comment.
maybe in a future PR :)
ashleynolan
approved these changes
Apr 23, 2024
xander-marjoram
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test form to use the newly styled pie-input component and uses the input for all fields in the integration form