Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSW-1897 - Resolve SSR server build via nuxt config moduleSideEffects… #115

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

kevinrodrigues
Copy link
Contributor

@kevinrodrigues kevinrodrigues commented Apr 24, 2024

This should resolve the SSR issues we experienced in the nuxt app. There are a couple things:

  1. Our icons seem to be an issue but I believe we're tackling that in another PR so will re-test once we have that done. In the meantime the integration > form & icons demo in SSR mode throws errors and won't render (it's fine in client mode)
  2. The issue predominantly looks to be an upstream issue from a Nitro package (the package that produces the server build, this for some reason does not respect imports only in server mode/folders so i've had to include the packages under the moduleSideEffects setting in nuxt.config.ts)
  3. I played around with the sideEffects package.json setting at component level (removed it and tried applying a different config but the error still persisted)
  4. I've bumped the packages for the following which did actually stop another 500 error from appearing nuxt, vue, vue-router and nuxt-ssr-lit
  5. Build scripts for preview and build have been updated.

@kevinrodrigues kevinrodrigues changed the title DSW-1897 - Resolve SSR server build via nuxt confif moduleSideEffects… DSW-1897 - Resolve SSR server build via nuxt config moduleSideEffects… Apr 24, 2024
@kevinrodrigues kevinrodrigues marked this pull request as ready for review April 26, 2024 09:35
@github-actions github-actions bot temporarily deployed to nuxt-app-pr-115 April 29, 2024 14:21 Inactive
@github-actions github-actions bot temporarily deployed to vanilla-app-pr-115 April 29, 2024 14:21 Inactive
@kevinrodrigues kevinrodrigues merged commit 6a69491 into main Apr 29, 2024
16 checks passed
@kevinrodrigues kevinrodrigues deleted the DSW-1897 branch April 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants