Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add customizable metric name prefix #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anitgandhi
Copy link

Previously, the metric name was always the query name, prefixed with sql_. Now, that remains the behavior if a prefix is not provided in the job config. An empty string may explicitly be provided, in which case sql_ is not prepended to the query name.

Previously, the metric name was always the query name, prefixed with `sql_`. Now, that remains the behavior if a prefix is not provided in the job config. An empty string may explicitly be provided, in which case `sql_` is not prepended to the query name.
@@ -118,6 +118,9 @@ For a more realistic example please have a look at [examples/kubernetes/configma
jobs:
# each job needs a unique name, it's used for logging and as an default label
- name: "example"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible point of discussion: i considered using the job name as the prefix, but 2 things stopped me from that:

  1. it would change the existing behavior (sql_ prefix) in a non-backwards-compatible way. however, since this hasn't hit a 1.0 release, i wasn't sure if that would be ok
  2. the job name is already used as a default label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant