[PAYMENT] Implemented beta controller and service, added swagger to the controller #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple of StripeService
# Conflicts: # pom.xml
…or payment controller, service and stripe service
…ed rental repository and made some sligth changes in create-payments yaml file
OlegStashkiv
approved these changes
Oct 3, 2023
| ) { | ||
| Payment payment = paymentService.create(requestDto); | ||
| URI url = URI.create(payment.getSessionUrl()); | ||
| System.out.println(url); |
There was a problem hiding this comment.
I think it's better to remove it
DmytroV95
requested changes
Oct 3, 2023
| import org.springframework.web.bind.annotation.RequestParam; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @Tag(name = "Payment controller", description = "Endpoint for managing payments") |
There was a problem hiding this comment.
Suggested change
| @Tag(name = "Payment controller", description = "Endpoint for managing payments") | |
| @Tag(name = "Payment management", description = "Endpoint for managing payments") |
To make a uniform style for controllers.
| import jakarta.validation.constraints.NotNull; | ||
| import lombok.Data; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
Suggested change
| @Data | |
| @Getter | |
| @Setter |
| @@ -0,0 +1,4 @@ | |||
| package com.project.carsharingapp.dto.payment; | |||
|
|
|||
| public class PaymentResponseDto { | |||
There was a problem hiding this comment.
What is the purpose of using empty class?
| @RequiredArgsConstructor | ||
| public class StripeService { | ||
| private static final String DEFAULT_URL_PART = "/api/payments"; | ||
|
|
| private static final String CANCEL_ENDPOINT = "cancel"; | ||
| private static final Long STANDARD_QUANTITY_OF_RENTAL_CART = 1L; | ||
| private static final String DEFAULT_CURRENCY = "USD"; | ||
| private final PaymentAmountHandlerStrategy handler; |
There was a problem hiding this comment.
Add whitespace between static and not static fields.
DmytroV95
changed the title
# Conflicts: # src/main/resources/application.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.