Some changes to start supporting Java 11 #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use OpenJFX 11 * Add annotation-api dependency * Remove tools.jar dependency * Use recent TestFX that accesses Robot properly This last bullet is not quite working; even though TestFX/TestFX#629 claims this has been fixed I continue to get NoClassDefFoundError when trying to run tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This last bullet is not quite working; even though
TestFX/TestFX#629 claims this has been fixed I continue to get
NoClassDefFoundError when trying to run tests.
This is a work in progress. The TestFX blocker is reported at TestFX/TestFX#691.
I'm hopeful that's the only blocker remaining for this to build and test successfully on Java 11.