Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/k0sproject/k0sctl from 0.20.0 to 0.20.1 in /hack/tool #5424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juanluisvaladas
Copy link
Contributor

Description

Bumps github.com/k0sproject/k0sctl from 0.20.0 to 0.21.0.

Bumps [github.com/k0sproject/k0sctl](https://github.com/k0sproject/k0sctl) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/k0sproject/k0sctl/releases)
- [Commits](k0sproject/k0sctl@v0.20.0...v0.21.0)

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
@juanluisvaladas juanluisvaladas requested review from a team as code owners January 9, 2025 13:13
@juanluisvaladas
Copy link
Contributor Author

OS tests for ubuntu 22.04 seem to work (not 100% sure) with k0sctl 0.21.0. Probably because of: k0sproject/k0sctl@ebf4911

@twz123
Copy link
Member

twz123 commented Jan 9, 2025

Can you elaborate? Seems to be a breaking change in k0s? Because it used to work with 0.20?

Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kubernetes dependencies should stay at 0.31.3. If k0sctl really needs Kubernetes 1.32, then we should wait with the bump until k0s is updated to Kubernetes 1.32.

Comment on lines +89 to +92
k8s.io/apimachinery v0.32.0 // indirect
k8s.io/client-go v0.32.0 // indirect
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/utils v0.0.0-20240921022957-49e7df575cb6 // indirect
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't update the k8s dependencies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants