Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type codedeploy and codedeploy_deployment_group #441

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Jan 20, 2019

First PR in this repo. Attempts to address #440

Add codedeploy resource types:

  • codedeploy
  • codedeploy_deployment_group

WIP because I'm currently getting the below failure when generating docs.
I'm slightly confused here as I have the application_name param passed into the get_deployment_group function: https://github.com/k1LoW/awspec/compare/master...kl4w:add-type-codedeploy?expand=1#diff-025a03cb0721734aa0ebab79071e2031R10

I'd appreciate any pointers here if possible.

$ bundle exec bin/toolbox docgen > doc/resource_types.md
ArgumentError: missing required parameter params[:application_name]
  /Users/klaw/Documents/code/klaw/awspec/lib/awspec/generator/doc/type.rb:22:in `eval'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/param_validator.rb:13:in `validate!'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/plugins/param_validator.rb:23:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/seahorse/client/plugins/raise_response_errors.rb:14:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/plugins/idempotency_token.rb:17:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/plugins/param_converter.rb:24:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/aws-sdk-core/plugins/response_paging.rb:10:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/seahorse/client/plugins/response_target.rb:23:in `call'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-core-3.46.0/lib/seahorse/client/request.rb:70:in `send_request'
  /Users/klaw/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/aws-sdk-codedeploy-1.13.0/lib/aws-sdk-codedeploy/client.rb:1807:in `get_deployment_group'
  /Users/klaw/Documents/code/klaw/awspec/lib/awspec/helper/client_wrap.rb:26:in `method_missing'
  /Users/klaw/Documents/code/klaw/awspec/lib/awspec/helper/finder/codedeploy.rb:10:in `find_codedeploy_deployment_group'
  /Users/klaw/Documents/code/klaw/awspec/lib/awspec/type/codedeploy_deployment_group.rb:11:in `resource_via_client'
  /Users/klaw/Documents/code/klaw/awspec/lib/awspec/generator/doc/type/codedeploy_deployment_group.rb:9:in `initialize'

@kl4w kl4w force-pushed the add-type-codedeploy branch 2 times, most recently from 37db4b0 to 344262a Compare February 7, 2019 15:10
@kl4w kl4w changed the title [WIP]: Add type codedeploy Add type codedeploy and codedeploy_deployment_group Feb 8, 2019
@kl4w
Copy link
Contributor Author

kl4w commented Feb 8, 2019

hi @k1LoW,

I figured out my error due to a "default" not being set: https://github.com/k1LoW/awspec/pull/441/files#diff-726d04686cfa36258f72777465e32f81R19

@k1LoW
Copy link
Owner

k1LoW commented Feb 11, 2019

Hi @kl4w !!! Thank you for your GREAT WORK !!!!

@k1LoW k1LoW merged commit 47e0e82 into k1LoW:master Feb 11, 2019
@k1LoW
Copy link
Owner

k1LoW commented Feb 11, 2019

Released as v1.15.0.

@kl4w kl4w deleted the add-type-codedeploy branch February 11, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants