Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with eval mode in ActivationDropoutLinear #1770

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Fix issue with eval mode in ActivationDropoutLinear #1770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d186216
Fix issue with eval mode in ActivationDropoutLinear
danpovey Oct 12, 2024
27198a3
change condition order
yaozengwei Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion egs/librispeech/ASR/zipformer/scaling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,7 @@ def __init__(
self.dropout_shared_dim = dropout_shared_dim

def forward(self, x: Tensor):
if torch.jit.is_scripting() or torch.jit.is_tracing():
if not self.training or torch.jit.is_scripting() or torch.jit.is_tracing():
if self.activation == "SwooshL":
x = SwooshLForward(x)
elif self.activation == "SwooshR":
Expand Down
Loading