Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kaldifeat for gcc 13 #1251

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

csukuangfj
Copy link
Collaborator

@meerfrau Please try this PR.

See also
#1250

@csukuangfj csukuangfj added the ready Ready for review and trigger GitHub actions to run label Oct 14, 2023
@rouseabout
Copy link

Applying this patch causes the following k2 build error.

python3 setup.py install

[...]

-- C++ Standard version: 17
-- BUILD_SHARED_LIBS ON
-- pybind11 is downloaded to /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-src
CMake Error at cmake/pybind11.cmake:72 (add_subdirectory):
  The binary directory

    /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-build

  is already used to build a source directory.  It cannot be used to build
  source directory

    /home/user/k2/build/temp.linux-x86_64-3.9/_deps/pybind11-src

  Specify a unique binary directory name.
Call Stack (most recent call first):
  cmake/pybind11.cmake:75 (download_pybind11)
  build/temp.linux-x86_64-3.9/_deps/kaldifeat-src/CMakeLists.txt:54 (include)

Appears both k2 and kaldifeat try to build pybind11?

@csukuangfj
Copy link
Collaborator Author

@rouseabout

Thanks for testing. Please use the latest commit of this PR.

I just updated the code to fix it.

@rouseabout
Copy link

Works. Thanks!

@csukuangfj
Copy link
Collaborator Author

Thank you again for testing. Merging.

@csukuangfj csukuangfj merged commit 45450bf into k2-fsa:master Nov 1, 2023
@csukuangfj csukuangfj deleted the update-kaldifeat-for-gcc-13 branch November 1, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for review and trigger GitHub actions to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants