Update JSON Schema: Correct the location of additionalProperties in the registries element
#1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorrrrrrrenzo
changed the title
registries.properties.additionalproperties => `registries.additiona…additionalProperties in the registries element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request moves
registries.properties.additionalpropertiestoregistries.additionalProperties, in accordance with the JSON Schema specification. …Why
I am creating this pull request because this nonconformance with the JSON Schema specification breaks an integration with a tool that consumes such schemas. The specification confirms that the
additionalPropertiesfield impacts the interpretation of other fields (source), suggesting that this is something worth fixing. Examples of the proper usage can be found here and here. We also see repeated uses of the keyword location/items/$ref/additionalPropertiesin the spec. If this key were properly located atregistries.properties.additionalproperties, we would see the use of/items/$ref/properties/additionalPropertiesinstead.Implications
I do not expect this to change any behavior.