Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB to CI #10724

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Add MariaDB to CI #10724

merged 5 commits into from
Sep 19, 2024

Conversation

robertsilen
Copy link
Contributor

Proposed Changes

I suggest to add MariaDB to CI testing.

Types of Changes

Change to CI test.

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

I identified where the database type is checked, and added a section for mariadb, but honestly I don't know how to take it further from here. Can I get some tips on how to work on this?

@robertsilen robertsilen requested a review from a team as a code owner August 16, 2024 12:31
tests/e2e/upgradecluster/Vagrantfile Outdated Show resolved Hide resolved
@brandond
Copy link
Member

I will also note that we do validate mariadb on the kine side: https://github.com/k3s-io/kine/blob/master/scripts/test-run-mysql#L28-L30

tests/e2e/validatecluster/Vagrantfile Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.92%. Comparing base (d6c20b7) to head (64678a8).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d6c20b7) and HEAD (64678a8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d6c20b7) HEAD (64678a8)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10724      +/-   ##
==========================================
- Coverage   49.82%   43.92%   -5.90%     
==========================================
  Files         178      178              
  Lines       14801    14801              
==========================================
- Hits         7374     6501     -873     
- Misses       6083     7096    +1013     
+ Partials     1344     1204     -140     
Flag Coverage Δ
e2etests 36.42% <ø> (-9.63%) ⬇️
inttests 19.72% <ø> (-17.01%) ⬇️
unittests 13.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robertsilen and others added 5 commits September 18, 2024 09:06
Signed-off-by: robertsilen <[email protected]>
Signed-off-by: robertsilen <[email protected]>
Signed-off-by: robertsilen <[email protected]>
Co-authored-by: Derek Nola <[email protected]>
Signed-off-by: Robert Silén <[email protected]>
Signed-off-by: robertsilen <[email protected]>
Co-authored-by: Derek Nola <[email protected]>
Signed-off-by: Robert Silén <[email protected]>
@dereknola dereknola merged commit 40eda6a into k3s-io:master Sep 19, 2024
29 checks passed
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
* add mariadb to Validate and Upgrade E2E tests

Signed-off-by: robertsilen <[email protected]>
Signed-off-by: Robert Silén <[email protected]>
Co-authored-by: Derek Nola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants