-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MariaDB to CI #10724
Add MariaDB to CI #10724
Conversation
I will also note that we do validate mariadb on the kine side: https://github.com/k3s-io/kine/blob/master/scripts/test-run-mysql#L28-L30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10724 +/- ##
==========================================
- Coverage 49.82% 43.92% -5.90%
==========================================
Files 178 178
Lines 14801 14801
==========================================
- Hits 7374 6501 -873
- Misses 6083 7096 +1013
+ Partials 1344 1204 -140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: robertsilen <[email protected]>
Signed-off-by: robertsilen <[email protected]>
Signed-off-by: robertsilen <[email protected]>
Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Robert Silén <[email protected]> Signed-off-by: robertsilen <[email protected]>
Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Robert Silén <[email protected]>
* add mariadb to Validate and Upgrade E2E tests Signed-off-by: robertsilen <[email protected]> Signed-off-by: Robert Silén <[email protected]> Co-authored-by: Derek Nola <[email protected]>
Proposed Changes
I suggest to add MariaDB to CI testing.
Types of Changes
Change to CI test.
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
I identified where the database type is checked, and added a section for mariadb, but honestly I don't know how to take it further from here. Can I get some tips on how to work on this?