Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonroot-devices flag to agent CLI #11200

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 30, 2024

Proposed Changes

Add new flag that is passed through to the device_ownership_from_security_context parameter in the containerd CRI config. This is not possible to change without providing a complete custom containerd.toml template so we should add a flag for it.

Types of Changes

enhancement

Verification

Testing

Linked Issues

User-Facing Change

`device_ownership_from_security_context` can now be enabled in the containerd CRI config by setting the `--nonroot-devices` flag or config key.

Further Comments

Add new flag that is passed through to the device_ownership_from_security_context parameter in the containerd CRI config. This is not possible to change without providing a complete custom containerd.toml template so we should add a flag for it.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner October 30, 2024 20:58
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.14%. Comparing base (a39e191) to head (c6fa868).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11200      +/-   ##
==========================================
- Coverage   47.06%   42.14%   -4.93%     
==========================================
  Files         179      179              
  Lines       18569    18572       +3     
==========================================
- Hits         8740     7827     -913     
- Misses       8474     9539    +1065     
+ Partials     1355     1206     -149     
Flag Coverage Δ
e2etests 33.97% <100.00%> (-8.25%) ⬇️
inttests 34.70% <100.00%> (-0.01%) ⬇️
unittests 13.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants