Readd k3s secrets-encrypt rotate-keys with correct support for KMSv2 GA
#9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
commented
Feb 1, 2024
| COPY ./tests ./tests | ||
| COPY ./.git ./.git | ||
| COPY ./pkg ./pkg |
There was a problem hiding this comment.
This is a docker caching optimization, as the COPY ./tests ./tests line will now be cached most of the time. COPY ./.git ./.git is now sometimes cached, just less so.
dereknola
commented
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9340 +/- ##
===========================================
- Coverage 40.53% 27.79% -12.74%
===========================================
Files 154 154
Lines 16555 13498 -3057
===========================================
- Hits 6710 3752 -2958
- Misses 8697 8958 +261
+ Partials 1148 788 -360
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
requested changes
Feb 2, 2024
brandond
requested changes
Feb 6, 2024
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
129_se_metrics
branch
from
112dbd5
to
307e4b8
Compare
brandond
requested changes
Feb 7, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
reviewed
Feb 7, 2024
brandond
requested changes
Feb 7, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
reviewed
Feb 7, 2024
brandond
reviewed
Feb 7, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
reviewed
Feb 8, 2024
brandond
reviewed
Feb 8, 2024
brandond
previously approved these changes
Feb 8, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Feb 8, 2024
matttrach
approved these changes
Feb 9, 2024
This was referenced Feb 9, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
rotate-keysanddisablecommands on non etcd-leader nodesTypes of Changes
Feature "Fix"
Verification
go test ./tests/e2e/secretsencryption/secretsencryption_test.goTesting
Reenabled the E2E test for this feature.
Linked Issues
#9080
User-Facing Change
Further Comments