Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.26] Test_UnitApplyContainerdQoSClassConfigFileIfPresent #9442

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

dereknola
Copy link
Member

Backport #8945

Linked Issues

#8844

User-Facing Change


Further Comments

…ed) (k3s-io#8945)

Problem:
Function not tested.

Solution:
Unit test added.

Signed-off-by: Oliver Larsson <[email protected]>
@dereknola dereknola requested a review from a team as a code owner February 9, 2024 19:35
Signed-off-by: Derek Nola <[email protected]>
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b5da7cf) 14.73% compared to head (ffcd25c) 14.85%.

Files Patch % Lines
pkg/agent/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #9442      +/-   ##
================================================
+ Coverage         14.73%   14.85%   +0.12%     
================================================
  Files               115      115              
  Lines              8457     8460       +3     
================================================
+ Hits               1246     1257      +11     
+ Misses             6961     6953       -8     
  Partials            250      250              
Flag Coverage Δ
unittests 14.85% <91.66%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit c74395c into k3s-io:release-1.26 Feb 12, 2024
15 checks passed
@dereknola dereknola deleted the qos_unit_126 branch February 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants