-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable direct gets and update nats-server and nats.go versions #281
Conversation
@brandond I check out the Drone CI and noticed that for the NATS 2.10.11, the API server was failing to come up, but its not clear why: |
@bruth as per #275 (comment) it sounds like this does not resolve the error? |
Checking it out again. |
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
5f60b40
to
a92110e
Compare
Found the root cause.. I had disabled an internal API that the KV bucket normally uses a while back since it was buggy at the time. However that had the side effect of having certain requests time out since directs gets were disabled. The error reporting simply appears as a timeout since there is not receiver of that direct get API. I validated the timeout no longer occurs when creating the health check key-value pair which will prevent the issue noted in #274. This has been likely affecting all deployments of kine+NATS. Also confirmed the CI passed this time. |
I will update with an additional commit shortly to ensure that API is enabled for existing KV buckets. |
Signed-off-by: Byron Ruth <[email protected]>
@brandond Assuming CI passes, this is now ready to be reviewed and merged. |
No description provided.