Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable direct gets and update nats-server and nats.go versions #281

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

bruth
Copy link
Contributor

@bruth bruth commented Mar 2, 2024

No description provided.

@bruth bruth requested a review from a team as a code owner March 2, 2024 12:29
@bruth
Copy link
Contributor Author

bruth commented Mar 2, 2024

@brandond I check out the Drone CI and noticed that for the NATS 2.10.11, the API server was failing to come up, but its not clear why:
image
NATS 2.9.25 and NATS embedded both worked.

@brandond
Copy link
Member

@bruth as per #275 (comment) it sounds like this does not resolve the error?

@bruth
Copy link
Contributor Author

bruth commented Mar 22, 2024

Checking it out again.

@bruth bruth force-pushed the update-nats-versions branch from 5f60b40 to a92110e Compare March 22, 2024 12:17
@bruth bruth changed the title Update NATS server 2.10.11 and Go client 1.33.1 Re-enable direct gets and update nats-server and nats.go versions Mar 22, 2024
@bruth
Copy link
Contributor Author

bruth commented Mar 22, 2024

Found the root cause.. I had disabled an internal API that the KV bucket normally uses a while back since it was buggy at the time. However that had the side effect of having certain requests time out since directs gets were disabled. The error reporting simply appears as a timeout since there is not receiver of that direct get API.

I validated the timeout no longer occurs when creating the health check key-value pair which will prevent the issue noted in #274. This has been likely affecting all deployments of kine+NATS.

Also confirmed the CI passed this time.

@bruth
Copy link
Contributor Author

bruth commented Mar 22, 2024

I will update with an additional commit shortly to ensure that API is enabled for existing KV buckets.

@bruth
Copy link
Contributor Author

bruth commented Mar 22, 2024

@brandond Assuming CI passes, this is now ready to be reviewed and merged.

@brandond brandond merged commit 774b2e8 into k3s-io:master Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants