Fix key order compliance #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
fix-key-order-compliance
branch
2 times, most recently
from
4286268 to
4070872
Compare
dereknola
approved these changes
May 8, 2024
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-key-order-compliance
branch
9 times, most recently
from
7c7eb06 to
2367648
Compare
* Sort list results by name, not revision. List continuation (start key) functionality requires that keys be returned in ascending order. * Only count keys remaining after the start key, not the total number of keys in the prefix. * Return current revision in header along with error when unable to range on key. * Don't ignore start key when listing with revision=0 Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-key-order-compliance
branch
from
2367648 to
91f512e
Compare
Bump k3s to v1.29.4+k3s1, and add basic sig-api-machinery e2e against sqlite and nats Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-key-order-compliance
branch
from
91f512e to
33f7751
Compare
|
hey @bruth are you able to take a look at the CI failures here, when running the Kubernetes sig-api-machinery e2e tests against a cluster using kine+nats-embedded? It appears to be failing on some pretty basic stuff: |
Signed-off-by: Brad Davidson <[email protected]>
|
@brandond Hey, sorry for the late response. I was traveling last week. I will take a look at it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: