remove non-working auto merge #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In k8gb-io#1615 auto merge was enabled for [all non-major dependencies](k8gb-io#1052 (comment)). However, the PR cannot be merged without an approving review. The missing piece would be the following app: https://github.com/apps/renovate-approve. It would approve all PRs created by the renovate bot that have auto merge enabled. Unfortunately, it cannot do it for projects that have CODEOWNERS setup, which is our case: > Important note: Due to a GitHub limitation, it is not possible to assign any app like this one as a CODEOWNER, so unfortunately this bot won't work that way if you have CODEOWNERS set up. Since auto merge does not work this PR removes the configuration to avoid any confusion Signed-off-by: abaguas <[email protected]>
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
ytsarev
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1615 auto merge was enabled for all non-major dependencies. However, the PR cannot be merged without an approving review. The missing piece would be the following app: https://github.com/apps/renovate-approve. It would approve all PRs created by the renovate bot that have auto merge enabled. Unfortunately, it cannot do it for projects that have CODEOWNERS setup, which is our case:
Since auto merge does not work in our setup this PR removes its configuration to avoid any confusion.