Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Replace network annotation function with client library function #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s1061123
Copy link
Member

This change remove network annotation function and use net-attach-def library function. As a result, it is independent from multus.

@s1061123 s1061123 requested a review from dougbtv October 17, 2022 07:19
@coveralls
Copy link

coveralls commented Oct 17, 2022

Pull Request Test Coverage Report for Build 3266863589

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.03%) to 43.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhook/webhook.go 0 1 0.0%
Totals Coverage Status
Change from base Build 2935993173: 8.03%
Covered Lines: 120
Relevant Lines: 273

💛 - Coveralls

@s1061123 s1061123 changed the title Replace network annotation function with client library function [WIP]Replace network annotation function with client library function Oct 17, 2022
This change remove network annotation function and use
net-attach-def library function. As a result, it is independent
from multus.

This also removes unnecessary files in deployments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants