[WIP] Rdma device rename in container #28
Conversation
pkg/utils/utils.go
Outdated
|
|
||
| "github.com/vishvananda/netlink" | ||
| ) | ||
|
|
||
| // Max netdevice length is 15 chars. see if.h linux uapi header IFNAMSIZ | ||
| const localIFNAMSIZ=16 |
There was a problem hiding this comment.
you can use the const https://golang.org/pkg/syscall/ it in hex
There was a problem hiding this comment.
I originally thought that its not needed to link against it but thinking on this further, i already use netlink which imports syscall
cmd/rdma/main.go
Outdated
| } | ||
|
|
||
| // Expected format is <driver_name>_<idx> | ||
| s := strings.Split(sRdmaDev, "_") |
There was a problem hiding this comment.
you can create on method that extract the driver and the index and use it here and getRdmaDevIndexFromName
pkg/utils/utils.go
Outdated
| } | ||
|
|
||
| func GetRandomRdmaDevName() string { | ||
| return fmt.Sprintf("rdmadev_%d", rand.Int31())[:(localIFNAMSIZ-1)] |
There was a problem hiding this comment.
doesn't each rdma device has it own index like net device?
There was a problem hiding this comment.
yes it has, do you prefer to use rdmadev_<rdma-dev-idx> ?
There was a problem hiding this comment.
it ok, just remove the random
- method to generate a random name - method to generate the "next" name
Extend RDMA manager API to facilitate RDMA device renmae when moving it to/form container network namespace - Add method to get available RDMA devices in the system - Add method to rename RDMA device
This commit implements the main flow for RDMA device rename
when moving the device to/from container
On CmdAdd: rename device to the next available rdma device name
according to the naming scheme defined in previous commit.
On CmdDel: Restore the name to its orignal name as was saved in cache
adrianchiris
force-pushed
the
rdma-rename
branch
from
24e202e to
9d3568e
Compare
| } | ||
|
|
||
| // Get the next RDMA device name for a given RDMA device prefix | ||
| func GetNextRdmaDeviceName(prefix string, currDevs []string) (string, error) { |
There was a problem hiding this comment.
@adrianchiris
I think it is better to use PCI device based naming scheme from
https://github.com/linux-rdma/rdma-core/blob/master/kernel-boot/rdma-persistent-naming.rules
And let rdma/hca operator to configure system for rdma device naming.
This PR adds the functionality of providing incrementing RDMA device name in container.
allowing for consistent RDMA device names in containers e.g
mlx5_0for the first RDMA enabled network,mlx5_1for the second RDMA enabled network etc...Missing: