-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optmize node watcher in daemon #634
Open
alan-kut
wants to merge
1
commit into
k8snetworkplumbingwg:master
Choose a base branch
from
alan-kut:pr-fix-node-watch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+57
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR,
To skip the vendors CIs use one of:
|
Node watcher is very heavy when watching all the nodes, not only the current one. Nodes are regularly updated, e.g. by kubelet. Watch only the current node all the time and other nodes only when holding the drain lock. Signed-off-by: Alan Kutniewski <[email protected]>
alan-kut
force-pushed
the
pr-fix-node-watch
branch
from
February 13, 2024 16:09
683f40c
to
b4ccc1a
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7889385247Details
💛 - Coveralls |
/test-all |
sure we can do it after we merge #555 |
Hi @alan-kut can you take a look on the operator now that we remove the nodes update from the config daemon we have it only on the controller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node watcher is very heavy when watching
all the nodes, not only the current one.
Nodes are regularly updated, e.g. by kubelet.
Watch only the current node all the time and
other nodes only when holding the drain lock.