Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Daemon redesign #788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Oct 10, 2024

No description provided.

Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

pkg/daemon/daemon.go Fixed Show fixed Hide fixed
@SchSeba SchSeba force-pushed the daemon_redesign branch 3 times, most recently from 9f5207e to 7d4e946 Compare October 10, 2024 10:23
@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 12354279067

Details

  • 271 of 614 (44.14%) changed or added relevant lines in 15 files are covered.
  • 208 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.8%) to 48.021%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/network/network.go 0 1 0.0%
pkg/host/store/store.go 0 1 0.0%
pkg/plugins/mellanox/mellanox_plugin.go 0 1 0.0%
pkg/daemon/config.go 30 32 93.75%
controllers/drain_controller.go 4 7 57.14%
pkg/systemd/systemd.go 2 6 33.33%
pkg/daemon/status.go 59 96 61.46%
cmd/sriov-network-config-daemon/start.go 7 141 4.96%
pkg/daemon/daemon.go 140 300 46.67%
Files with Coverage Reduction New Missed Lines %
pkg/systemd/systemd.go 4 25.24%
pkg/client/clientset/versioned/fake/clientset_generated.go 5 46.15%
cmd/sriov-network-config-daemon/start.go 5 8.64%
pkg/client/informers/externalversions/sriovnetwork/interface.go 6 0.0%
pkg/plugins/fake/fake_plugin.go 6 20.0%
pkg/client/informers/externalversions/sriovnetwork/v1/interface.go 9 0.0%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovoperatorconfig.go 15 10.81%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovnetworknodestate.go 17 25.68%
pkg/client/informers/externalversions/sriovnetwork/v1/sriovnetworknodestate.go 19 0.0%
pkg/client/informers/externalversions/sriovnetwork/v1/sriovoperatorconfig.go 19 0.0%
Totals Coverage Status
Change from base Build 12298677979: 0.8%
Covered Lines: 7255
Relevant Lines: 15108

💛 - Coveralls

@SchSeba SchSeba force-pushed the daemon_redesign branch 2 times, most recently from e17b584 to ddc70f2 Compare October 10, 2024 12:45
@SchSeba SchSeba force-pushed the daemon_redesign branch 2 times, most recently from 929886d to 9377404 Compare December 12, 2024 11:54
@SchSeba SchSeba force-pushed the daemon_redesign branch 3 times, most recently from f1b4967 to 79cc69b Compare December 16, 2024 13:46
Signed-off-by: Sebastian Sch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants