functest: add retry for rdma functionel test #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
SchSeba
force-pushed
the
add_retry_on_delete
branch
from
704d7ec to
f68bdf1
Compare
Pull Request Test Coverage Report for Build 12373006144Details
💛 - Coveralls |
zeeke
reviewed
Dec 16, 2024
Comment on lines
103
to
109
| output, _, err = runCommandOnConfigDaemon(testNode, "/bin/bash", "-c", "cat /host/proc/cmdline | grep ib_core.netns_mode=0 | wc -l") | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(strings.HasPrefix(output, "0")).To(BeTrue()) | ||
| Expect(strings.HasPrefix(output, "0")).To(BeTrue(), fmt.Sprintf("kernel args are not right, printing current kernel args %s", cmdlineOutput)) | ||
|
|
||
| output, _, err = runCommandOnConfigDaemon(testNode, "/bin/bash", "-c", "cat /host/proc/cmdline | grep ib_core.netns_mode=1 | wc -l") | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| Expect(strings.HasPrefix(output, "1")).To(BeTrue()) | ||
| Expect(strings.HasPrefix(output, "1")).To(BeTrue(), fmt.Sprintf("kernel args are not right, printing current kernel args %s", cmdlineOutput)) |
There was a problem hiding this comment.
can we refactor this to?
Expect(cmdlineOutput).To(ContainSubstring("ib_core.netns_mode=1"))
Expect(cmdlineOutput).ToNot(ContainSubstring("ib_core.netns_mode=0"))The same for the other /host/proc/cmdline asssertion
There was a problem hiding this comment.
you are right less execs!
this is needed because after a reboot on a single node the operator webhook may not be ready Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
add_retry_on_delete
branch
from
f68bdf1 to
0c4edb3
Compare
e0ne
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed because after a reboot on a single node the operator webhook may not be ready