Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

update stacks build task to add new secure config option #338

Merged
merged 2 commits into from
May 14, 2020
Merged

update stacks build task to add new secure config option #338

merged 2 commits into from
May 14, 2020

Conversation

arunavemulapalli
Copy link

@arunavemulapalli arunavemulapalli commented May 12, 2020 •
edited
Loading

Checklist:

Updates to the collections

  1. add new option "secure" in the stacks-build-task - If secure=proxy, then the stack-hub index deployment will have openshift oauth proxy sidecar in addition to nginx container.

Related Issues:

Related to - kabanero-io/kabanero-security#69

@CLAassistant
Copy link

CLAassistant commented May 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

groeges
groeges previously approved these changes May 13, 2020
View reviewed changes
Copy link

@groeges groeges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@arunavemulapalli arunavemulapalli force-pushed the secure_stackhub_index branch from ce6453a to 29f8cac Compare May 13, 2020 15:27
@arunavemulapalli
Copy link
Author

Completed testing using these updates successfully.

groeges
groeges approved these changes May 14, 2020
View reviewed changes
Copy link

@groeges groeges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groeges groeges merged commit 4bdb2aa into kabanero-io:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@groeges groeges groeges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunavemulapalli @CLAassistant @groeges