Skip to content

Commit

Permalink
Add padding for icon (#98)
Browse files Browse the repository at this point in the history
* Making 96x96(almost) with GIMP is toooo hard for me...

Padding in 128 will be done imagemagick

* I cannot be friend of GIMP...
  • Loading branch information
kachick authored Mar 25, 2024
1 parent 239efd3 commit 4fe0a7b
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions assets/icons/3.edit_by_me/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
## How to make the adjusted file

Spec: https://developer.chrome.com/docs/webstore/images?hl=en#icons

Fight with GIMP to crop 96x96

And imagemagick

```bash
convert assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-3-96.png -gravity center -background white -extent 128x128 assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-3-128x128.png
convert assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-3-128x128.png -transparent white assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-3-128x128-t.png
```

But the cropping is not perfect, having ugly edge...
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
2 changes: 1 addition & 1 deletion scripts/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const gatherDist = Promise.all([
Deno.copyFile('src/options.css', 'dist/options.css'),
Deno.copyFile('vendor/primer.css', 'dist/primer.css'),
Deno.copyFile(
'assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-gimp.png',
'assets/icons/3.edit_by_me/from-icon-sadness-star-2024-03-25-128x128-t.png',
'dist/icon-sadness-star.png',
),
]);
Expand Down

0 comments on commit 4fe0a7b

Please sign in to comment.