Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump flake.lock and related dependencies - including gitleaks v8.18.3 added false positive with the facebook-page-access-token #783

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Bump flake.lock and related dependencies - including gitleaks v8.18.3 added false positive with the facebook-page-access-token #783

merged 4 commits into from
Sep 12, 2024

Conversation

selfup-runner[bot]
Copy link
Contributor

@selfup-runner selfup-runner bot commented Sep 12, 2024

This PR has been created by reusable workflow in https://github.com/kachick/selfup/tree/main/.github/workflows

Do NOT work in the branch of this PR, it may be updated by the bot with force push.

@github-actions
flake.lock: Update
893b709 
Flake lock file updates:

• Updated input 'edge-nixpkgs':
    'github:NixOS/nixpkgs/574d1eac1c200690e27b8eb4e24887f8df7ac27c?narHash=sha256-v3rIhsJBOMLR8e/RNWxr828tB%2BWywYIoajrZKFM%2B0Gg%3D' (2024-09-06)
  → 'github:NixOS/nixpkgs/1355a0cbfeac61d785b7183c0caaec1f97361b43?narHash=sha256-4b3A9zPpxAxLnkF9MawJNHDtOOl6ruL0r6Og1TEDGCE%3D' (2024-09-10)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/68e7dce0a6532e876980764167ad158174402c6f?narHash=sha256-ZPzhebbWBOr0zRWW10FfqfbJlan3G96/h3uqhiFqmwg%3D' (2024-09-07)
  → 'github:NixOS/nixpkgs/44a71ff39c182edaf25a7ace5c9454e7cba2c658?narHash=sha256-RVhD9hnlTT2nJzPHlAqrWqCkA7T6CYrP41IoVRkciZM%3D' (2024-09-10)
@kachick
Copy link
Owner

kachick commented Sep 12, 2024 •
edited
Loading

This PR having gitleaks detection, but it looks one of false positive for facebook-page-access-token

  1. I have checking gitleaks with both nixpkgs and https://github.com/gitleaks/gitleaks-action, action looks using old version gitleaks version: 8.16.1 https://github.com/kachick/dotfiles/actions/runs/10821891434/job/30024801702 and nixpkgs using newer 8.18.3 [Backport release-24.05] gitleaks: 8.18.2 -> 8.18.3 NixOS/nixpkgs#335265
  2. facebook-page-access-token is applied since 8.18.3 feat: facebook secret, access token, and page access token rules gitleaks/gitleaks#1372
  3. That is detecting

    dotfiles/darwin/Terminal/Iceberg.terminal

    Line 170 in 04f2bf8

    WVogAAAAAAAAJKAAAA+EAAC2z2Rlc2MAAAAAAAAAFklFQyBodHRwOi8vd3d3LmllYy5j
    EAAC2z2Rlc2MAAAAAAAAAFklFQyBodHRwOi8vd3d3LmllYy5j as a facebook-page-access-token, however that should not be. This string is used in wide... https://gist.github.com/cocopon/a04be63f5e0856daa594702299c13160#file-iceberg-terminal-L170

image
image

@kachick
Copy link
Owner

kachick commented Sep 12, 2024 •
edited
Loading

How to resolve 🤔

@kachick kachick changed the title Bump flake.lock and related dependencies Bump flake.lock and related dependencies - including gitleaks false positive with the facebook-page-access-token Sep 12, 2024
@kachick
Copy link
Owner

kachick commented Sep 12, 2024

💭 Ah, gitleaks action detect only diff commits...

@kachick kachick changed the title Bump flake.lock and related dependencies - including gitleaks false positive with the facebook-page-access-token Bump flake.lock and related dependencies - including gitleaks v8.18.3 added false positive with the facebook-page-access-token Sep 12, 2024
@kachick kachick merged commit ebeb081 into main Sep 12, 2024
17 checks passed
@kachick kachick deleted the bot-update-flake-lock branch September 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🛸
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kachick