Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to use buildFHSEnv for zed-editor to fix ENOSPC error #810

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented Oct 1, 2024

Attempt to fix GH-809

But this makes regression for GH-781 again with reverting ae380db

@@ -20,6 +20,33 @@
"tabs": {
"file_icons": true
},
"lsp": {
"vscode-json-language-server": {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not working.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But keeping this code for now. For daily testing...

@kachick kachick changed the title Avoid to use buildFHSEnv for zed-editor to fix ENOSPC error Avoid to use buildFHSEnv for zed-editor to fix ENOSPC error Oct 1, 2024
@@ -237,7 +231,7 @@ in
);

environment.variables = {
VISUAL = "${lib.getExe zed-fhs} --wait";
VISUAL = "${lib.getExe edge-pkgs.zed-editor} --wait";
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#755 again. It is frustrated in these changes...

@kachick kachick marked this pull request as ready for review October 1, 2024 15:37
@kachick kachick merged commit 630d812 into main Oct 1, 2024
15 checks passed
@kachick kachick deleted the avoid-fhsenv branch October 1, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open buildFHSEnv wrapped zed-editor with bwrap ENOSPC error
1 participant