-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement startupGracePeriod
in wait-list
#821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
May 29, 2024
With changing error reporting method from raising JS error
kachick
changed the title
Implement margin for first validation
Implement May 29, 2024
startupGracePeriod
This reverts commit 47682d0.
kachick
changed the title
Implement
Implement Jun 2, 2024
startupGracePeriod
startupGracePeriod
in wait-list
kachick
added a commit
that referenced
this pull request
Jun 2, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #820
waitForFirstValidation
=>marginOfStartingTime
=>startupGracePeriod
=>gracePeriod
?Temporal
for duration unit, but keep current settingswait-seconds-before-first-polling
andmin-interval-seconds
for compatibility