Enable external keys #753
Draft
Enable external keys #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosuavio
force-pushed
the
external-keys
branch
8 times, most recently
from
6c13424
to
5c16914
Compare
Rosuavio
force-pushed
the
external-keys
branch
4 times, most recently
from
5365888
to
5c67e0e
Compare
Rosuavio
force-pushed
the
external-keys
branch
7 times, most recently
from
e92d7fe
to
e171c7b
Compare
Moved common singing functions to to Frontend.UI.Dialogs.Signing.Common
Changed pubKeyFromWiget to take a KeyStorage for key suggestions instead of using uiComboBoxGlobalDatalist to suggest keys directly from the global key store.
- Enable external PublicKeys to be provided for as keys for capabilites - When attempting to build the DeploymentSettingsResult, throw and error if not every Public Key in the payload matches has a KeyPair in the wallet. Other wise use the wallet to provide with KeyPairs for the payload.
TODO Make it so that when a user selects any key for a capability that is in the list of unrestricted keys the key is removed from the list of unrestricted keys. Prevent the user from inputing an unrestricted key if the key is already used as a key for a capability
The "signingKeys" and "extraKeys" were being treated the same anyways to this unifies it to "publicKeys"
Added new tab to deploy contract called "External Signatures". Users can provide private keys or signatues for every external public key in the payload.
madeline-os
reviewed
May 10, 2022
| forM pubKeys $ \pubKey -> do | ||
| sig pubKey | ||
|
|
||
| let sigs = distributeListOverDyn ddsigs |
| _ <- divClass "group" $ do | ||
| uiPreviewItem "Request Key" $ el "code" $ text (Pact.hashToText hash) | ||
|
|
||
| let mkKeyTuple (KeyPair pub priv) = (pub, priv) |
| cmd <- buildCmdWithPayload payload [] | ||
| -- Incomplete pattern match should be fine here because all the possible | ||
| -- commands are statically generated by Chainweaver. | ||
| let Right sd = commandToSigData cmd |
| -- commands are statically generated by Chainweaver. | ||
| let Right sd = commandToSigData cmd | ||
| let hash = Pact.toUntypedHash $ _sigDataHash sd | ||
| _ <- divClass "group" $ do |
| (Set.toList allPublicKeys <> _deploymentSettingsConfig_extraSigners settings) | ||
| code' (HM.union jsonData' deploySettingsJsonData) caps | ||
|
|
||
| -- TODO: are we worried about multiple private keys with the same pubkey key? |
| uiSenderCapabilities m mCaps = do | ||
| let keyPairDropdown ev = uiKeyPairDropdown m $ def & dropdownConfig_setValue .~ fmap Just ev | ||
| let | ||
| -- TODO: With the uiKeyPairDropdown it the user can select an empty item. |
| pb <- getPostBuild | ||
|
|
||
| let deploySettingsJsonData = fromMaybe mempty $ _deploymentSettingsConfig_data settings | ||
| jsonData0 = fromMaybe mempty $ hush jData | ||
| signingPairs = Map.keys capabilities <> Set.toList signers | ||
| publicKeyCapabilities = disregardPrivateKey capabilities | ||
| -- TODO: If we have PublicKeys that are not in the keyStore then signingPairs does not contain all the keys in the Paylaod! |
Rosuavio
force-pushed
the
external-keys
branch
2 times, most recently
from
aed0586
to
9eaae75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.