Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for deployment labels #27

Merged
merged 4 commits into from
Oct 9, 2024
Merged

feat: add support for deployment labels #27

merged 4 commits into from
Oct 9, 2024

Conversation

dadangnh
Copy link
Contributor

@dadangnh dadangnh commented Oct 1, 2024

Fixes #18

@dadangnh dadangnh requested a review from a team as a code owner October 1, 2024 04:40
@dadangnh
Copy link
Contributor Author

dadangnh commented Oct 6, 2024

Hi @Haarolean, the PR has been tested on our env and it works to solve this issue. Please have a look and let me know if you have any concern.

Thanks

@germanosin
Copy link
Member

@dadangnh Thanks for your contribution!
@azatsafin please check this

azatsafin
azatsafin approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@azatsafin azatsafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed description of the label param
Overral LGTM

@azatsafin azatsafin merged commit 212a3c1 into kafbat:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azatsafin azatsafin azatsafin approved these changes

Assignees

@azatsafin azatsafin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add deployment custom labels
3 participants
@dadangnh @germanosin @azatsafin