Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Do not format size units if value < 0 #201

Closed
Leshe4ka opened this issue Mar 12, 2024 · 0 comments · Fixed by #202
Closed

FE: Do not format size units if value < 0 #201

Leshe4ka opened this issue Mar 12, 2024 · 0 comments · Fixed by #202
Assignees
@Leshe4ka
Labels
good first issue Up for grabs scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Milestone
1.0

Comments

@Leshe4ka
Copy link
Contributor

Leshe4ka commented Mar 12, 2024 •
edited by Haarolean
Loading

TODO

  1. Don't show units for Broker config measured in bytes if value < 0
  2. Sorting has been moved out of the scope
@Leshe4ka Leshe4ka added scope/frontend Related to frontend changes status/triage Issues pending maintainers triage type/feature A brand new feature labels Mar 12, 2024
@Leshe4ka Leshe4ka self-assigned this Mar 12, 2024
@kapybro kapybro bot added status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 12, 2024
@Haarolean Haarolean added good first issue Up for grabs type/chore Boring stuff, could be refactoring or tech debt and removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Mar 12, 2024
@kafbat kafbat deleted a comment from github-actions bot Mar 12, 2024
@Leshe4ka Leshe4ka linked a pull request Mar 12, 2024 that will close this issue
FE: Do not format size units if value < 0 #202
Merged
13 tasks
@Haarolean Haarolean changed the title Remove units for Broker config measured in bytes if value < 0 FE: Do not format size units if value < 0 Mar 13, 2024
@Haarolean Haarolean added this to the 1.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leshe4ka Leshe4ka

Labels
good first issue Up for grabs scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Up for grabs
Status: No status
Release 1.0
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

FE: Do not format size units if value < 0 kafbat/kafka-ui
2 participants
@Haarolean @Leshe4ka