Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Do not format size units if value < 0 #202

Merged
merged 3 commits into from
Mar 13, 2024
Merged

FE: Do not format size units if value < 0 #202

merged 3 commits into from
Mar 13, 2024

Conversation

Leshe4ka
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Leshe4ka Leshe4ka added the scope/frontend Related to frontend changes label Mar 12, 2024
@Leshe4ka Leshe4ka requested a review from Haarolean March 12, 2024 13:09
@Leshe4ka Leshe4ka self-assigned this Mar 12, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 12, 2024
@Leshe4ka Leshe4ka linked an issue Mar 12, 2024 that may be closed by this pull request
@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Mar 13, 2024
@Haarolean Haarolean changed the title Remove units for Broker config measured in bytes if value < 0 FE: Do not format size units if value < 0 Mar 13, 2024
@Haarolean Haarolean merged commit 1ef2557 into main Mar 13, 2024
32 of 36 checks passed
@Haarolean Haarolean deleted the kafbat/201 branch March 13, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Do not format size units if value < 0
2 participants