Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Messages API v2 #115

Merged
merged 16 commits into from
Mar 16, 2024
Merged

BE: Messages API v2 #115

merged 16 commits into from
Mar 16, 2024

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Feb 10, 2024 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

github-actions[bot]
github-actions bot reviewed Feb 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there iliax! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

iliax added 2 commits February 10, 2024 21:05
Merge branch 'main' of github.com:kafbat/kafka-ui into messages_v2
6553180 
� Conflicts:
�	api/src/main/java/io/kafbat/ui/emitter/MessageFilters.java
�	api/src/main/java/io/kafbat/ui/service/MessagesService.java
�	api/src/test/java/io/kafbat/ui/service/MessagesServiceTest.java
Main merged
ddf6e3c
@iliax iliax requested review from DementevNikita, germanosin and Haarolean and removed request for DementevNikita and germanosin February 10, 2024 17:15
@iliax iliax requested review from germanosin and Haarolean and removed request for Haarolean and germanosin February 10, 2024 20:06
@iliax iliax requested review from germanosin and removed request for Haarolean February 11, 2024 07:19
@Haarolean Haarolean changed the title Messages v2 BE: Messages API v2 Mar 7, 2024
@Haarolean Haarolean linked an issue Mar 13, 2024 that may be closed by this pull request
Messages V2: API overhaul #47
Closed
@Haarolean Haarolean removed the request for review from germanosin March 15, 2024 05:46
@Haarolean Haarolean self-requested a review March 15, 2024 05:46
Haarolean
Haarolean approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised #212 but the rest is cool. Thanks!

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes type/refactor Refactoring task status/triage/completed Automatic triage completed area/messages labels Mar 15, 2024
@Haarolean Haarolean self-assigned this Mar 15, 2024
@Haarolean Haarolean merged commit d637fa2 into main Mar 16, 2024
5 of 9 checks passed
@Haarolean Haarolean deleted the messages_v2 branch March 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Haarolean Haarolean

Labels
area/messages scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature type/refactor Refactoring task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages V2: API overhaul
2 participants
@iliax @Haarolean