Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Add tsc & gen:sources for the build phase #177

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

Haarolean
Copy link
Member

  • Added tsc run for the build phase (there were no ts checks upon build for years)
  • Added sources generation for the build phase (to validate that the contract is valid)
  • Refactored vite config, added vite-plugin-checker to display ts & linter issues in dev mode

@Haarolean Haarolean added the type/refactor Refactoring task label Feb 27, 2024
@Haarolean Haarolean added this to the 1.0 milestone Feb 27, 2024
@Haarolean Haarolean self-assigned this Feb 27, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 27, 2024
@Haarolean Haarolean added the scope/frontend Related to frontend changes label Feb 27, 2024
@Mgrdich
Copy link
Contributor

Mgrdich commented Feb 27, 2024

i like this but let's test it out for a bit vite-plugin-checker see if it affects the speed of vite server.

@Haarolean
Copy link
Member Author

i like this but let's test it out for a bit vite-plugin-checker see if it affects the speed of vite server.

@Mgrdich does it matter? As it's dev mode only

@Mgrdich
Copy link
Contributor

Mgrdich commented Feb 27, 2024

For developer experience it might :) , i meant us the developers see if we notice any delay in our dev servers.

@Leshe4ka
Copy link
Contributor

i like this but let's test it out for a bit vite-plugin-checker see if it affects the speed of vite server.

It doesn't affect speed of vite dev server. Vite is fast. Vite hmr could be slow if in large projects a lot of named exports from index.ts , but this is not our case.

# Conflicts:
#	frontend/src/components/Topics/Topic/Messages/Filters/Filters.tsx
@Haarolean Haarolean merged commit b0cf76b into main Mar 1, 2024
4 of 8 checks passed
@Haarolean Haarolean deleted the fix/ts-checks branch March 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants