Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Fix double LDAP bean init #220

Merged
merged 4 commits into from
Apr 2, 2024
Merged

BE: Fix double LDAP bean init #220

merged 4 commits into from
Apr 2, 2024

Conversation

alexeyzavyalov
Copy link
Contributor

@alexeyzavyalov alexeyzavyalov commented Mar 16, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #205

Enabled loading of LdapAutoConfigurartion
Removed explicit import of LdapAutoConfigurartion

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@alexeyzavyalov alexeyzavyalov requested a review from a team as a code owner March 16, 2024 20:53
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 16, 2024
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels Mar 16, 2024
@kafbat kafbat deleted a comment from github-advanced-security bot Mar 17, 2024
@Haarolean Haarolean added this to the 1.1 milestone Mar 18, 2024
@Haarolean Haarolean removed this from the 2.0 milestone Mar 30, 2024
@Haarolean Haarolean changed the title Fix spring boot config for LdapAutoConfiguration BE: Fix double LDAP bean init Mar 30, 2024
Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Haarolean Haarolean merged commit c7b4d16 into main Apr 2, 2024
7 of 8 checks passed
@Haarolean Haarolean deleted the issues/205 branch April 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth App authentication related issues scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP: Bean LdapContextSource initialized twice
3 participants