-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: Implement previous button in topic messages page #550
Open
hadisfr
wants to merge
12
commits into
kafbat:main
Choose a base branch
from
hadisfr:feature/previous_button_in_topic_messages_page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FE: Implement previous button in topic messages page #550
hadisfr
wants to merge
12
commits into
kafbat:main
from
hadisfr:feature/previous_button_in_topic_messages_page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
Issues pending maintainers triage
status/triage/manual
Manual triage in progress
area/messages
status/triage/completed
Automatic triage completed
and removed
status/triage
Issues pending maintainers triage
labels
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi hadisfr! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
force-pushed
the
feature/previous_button_in_topic_messages_page
branch
from
September 17, 2024 15:39
89021aa
to
2e81741
Compare
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 17, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 18, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 18, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 18, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 18, 2024
Haarolean
added
type/enhancement
En enhancement/improvement to an already existing feature
scope/frontend
Related to frontend changes
scope/backend
Related to backend changes
and removed
status/triage/manual
Manual triage in progress
labels
Sep 18, 2024
Waiting for this change to get available. |
hadisfr
force-pushed
the
feature/previous_button_in_topic_messages_page
branch
from
September 21, 2024 10:11
611c55c
to
d77352a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/messages
scope/backend
Related to backend changes
scope/frontend
Related to frontend changes
status/triage/completed
Automatic triage completed
type/enhancement
En enhancement/improvement to an already existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
This PR adds the Previous button to the topic messages page.
This button used to be there in the provectus version, but was broken and has been removed in kafbat since migration to messages API v2.
This PR somehow addresses #270.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested?
We checked the aforementioned page extensively and ran the maven tests.
Checklist
Check out Contributing and Code of Conduct
A picture of a cute animal
P.S. Sorry but it seems that I don't have access to set label nor to ask a reviewer to review my changes, as requested in docs.
Also, checking all boxes of "How Has This Been Tested" seems irrelevant, but it causes failure of automatic check of PR.