Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Implement previous button in topic messages page #550

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

hadisfr
Copy link

@hadisfr hadisfr commented Sep 17, 2024

  • Breaking change?

What changes did you make?

This PR adds the Previous button to the topic messages page.
This button used to be there in the provectus version, but was broken and has been removed in kafbat since migration to messages API v2.

This PR somehow addresses #270.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested?

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

We checked the aforementioned page extensively and ran the maven tests.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal
IMG_20240917_224816_951.jpg

P.S. Sorry but it seems that I don't have access to set label nor to ask a reviewer to review my changes, as requested in docs.
Also, checking all boxes of "How Has This Been Tested" seems irrelevant, but it causes failure of automatic check of PR.

@hadisfr hadisfr requested review from a team as code owners September 17, 2024 15:38
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hadisfr! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
@hadisfr hadisfr force-pushed the feature/previous_button_in_topic_messages_page branch from 89021aa to 2e81741 Compare September 17, 2024 15:39
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Sep 18, 2024
@GagananandiC
Copy link

Waiting for this change to get available.

@hadisfr hadisfr force-pushed the feature/previous_button_in_topic_messages_page branch from 611c55c to d77352a Compare September 21, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants