Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cve_checks.yml with SHORT_SHA #617

Closed
wants to merge 1 commit into from

Conversation

vivekkoya
Copy link

@vivekkoya vivekkoya commented Oct 17, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves issue #581
Is there anything you'd like reviewers to focus on?
Please let me know if you require the hash to be alternate length.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@vivekkoya vivekkoya requested a review from a team as a code owner October 17, 2024 10:15
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi vivekkoya! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean
Copy link
Member

@vivekkoya hi, thanks for your PR. This has to be changed in all workflows, not just the cve one.

@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. status/feedback-requested and removed status/triage/manual Manual triage in progress labels Oct 17, 2024
Copy link

kapybro bot commented Oct 20, 2024

Further user feedback is requested. Please reply within 7 days or we might close the issue.

Copy link

kapybro bot commented Oct 27, 2024

No feedback received within 7 days. Auto closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants