Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Chore: Upgrade java to 21 #628

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sixdouglas
Copy link
Contributor

@sixdouglas sixdouglas commented Oct 19, 2024

Resolves #490
bump java version to 21

  • kafka client: 3.3.1 -> 3.8.0
  • aspectj: 1.9.9.1 -> 1.9.21

Maven Plugins:

  • clean: 3.2.0 -> 3.4.0
  • compile: 3.10.1 -> 3.13.0
  • resources: 3.2.0 -> 3.3.1
  • surefire: 3.1.2 -> 3.5.1
  • openapi generator : 6.6.0 -> 7.9.0
  • springdoc openapi webflux: 1.2.32 -> 1.8.0
  • surefire: 3.2.3 -> 3.5.1 (for e2e tests)
  • surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 19, 2024
@sixdouglas
Copy link
Contributor Author

Hi @Haarolean,

Here is another PR to bump versions of several components, trying to go to Java 21 another step to #490.

I still haven't been able to run the smoke, regression or sanity tests on my Mac M1. I've managed to solve some issues around docker incompatibilities like kdsqldbor the create-connectors images in the documentation/compose/e2e-tests.yaml file.

@Haarolean
Copy link
Member

Yeah I remember having issues with running e2e on m1 as well, mostly due to x86-based images in e2e compose. As an alternative, you can run them in your forked repo.

@sixdouglas
Copy link
Contributor Author

The build is failing, it seems that it uses the version of the scripts on the main branch and not the updated ones in the PR.
Screenshot 2024-10-19 at 21 00 54
Screenshot 2024-10-19 at 21 01 16

@sixdouglas
Copy link
Contributor Author

As an alternative, you can run them in your forked repo.

I didn't know I could do that, do you have a link to explain it?

@sixdouglas
Copy link
Contributor Author

I still can't make the e2e tests work locally.
But I was able to reproduce and fix the exception raised in the smoke tests you run.

@Haarolean
Copy link
Member

As an alternative, you can run them in your forked repo.

I didn't know I could do that, do you have a link to explain it?

sorry I don't have any articles on this, the point is that you can fork the repo and run whatever changes you need even on modified workflows in the fork repo :) There will be some failing tasks (due to lack of set secrets) like release and e2e reports uploading, but that's not that important.

@Haarolean
Copy link
Member

I still can't make the e2e tests work locally. But I was able to reproduce and fix the exception raised in the smoke tests you run.

oh, thanks much! 😄

@Haarolean Haarolean marked this pull request as ready for review October 22, 2024 17:49
@Haarolean Haarolean requested review from a team as code owners October 22, 2024 17:49
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 22, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All workflows seem to be passing successfully on a fork

@Haarolean Haarolean added scope/backend Related to backend changes scope/infra CI, CD, dev. env, etc. type/chore Boring stuff, could be refactoring or tech debt type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Oct 24, 2024
@Haarolean Haarolean changed the title chore(bump): bump java version to 21 BE: Chore: Upgrade java to 21 Oct 24, 2024
- kafka client: 3.3.1 -> 3.8.0
- aspectj: 1.9.9.1 -> 1.9.21

Maven Plugins:
- clean: 3.2.0 -> 3.4.0
- compile: 3.10.1 -> 3.13.0
- resources: 3.2.0 -> 3.3.1
- surefire: 3.1.2 -> 3.5.1
- openapi generator : 6.6.0 -> 7.9.0
- springdoc openapi webflux: 1.2.32 -> 1.8.0
- surefire: 3.2.3 -> 3.5.1 (for e2e tests)
- surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
- kafka client: 3.3.1 -> 3.8.0
- aspectj: 1.9.9.1 -> 1.9.21

Maven Plugins:
- clean: 3.2.0 -> 3.4.0
- compile: 3.10.1 -> 3.13.0
- resources: 3.2.0 -> 3.3.1
- surefire: 3.1.2 -> 3.5.1
- openapi generator : 6.6.0 -> 7.9.0
- springdoc openapi webflux: 1.2.32 -> 1.8.0
- surefire: 3.2.3 -> 3.5.1 (for e2e tests)
- surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
- kafka client: 3.3.1 -> 3.8.0
- aspectj: 1.9.9.1 -> 1.9.21
- byte-buddy: 1.12.19 -> 1.14.19
- mockito: 5.11.0 -> 5.14.2

Maven Plugins:
- clean: 3.2.0 -> 3.4.0
- compile: 3.10.1 -> 3.13.0
- resources: 3.2.0 -> 3.3.1
- surefire: 3.1.2 -> 3.5.1
- openapi generator : 6.6.0 -> 7.9.0
- springdoc openapi webflux: 1.2.32 -> 1.8.0
- surefire: 3.2.3 -> 3.5.1 (for e2e tests)
- surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
Copy link
Member

@germanosin germanosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt type/dependencies A pull request/issue dedicated to updating the dependency(-ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 21
3 participants