Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against undefined partition worker pid #581

Closed
wants to merge 2 commits into from
Closed

Guard against undefined partition worker pid #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261c916
Guard against undefined partition worker pid
urmastalimaa Jun 14, 2024
43f8f9c
Add changelog for version 3.19.1
urmastalimaa Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

- 3.19.1
- Guard against crashes in `brod_client:get_consumer/3` [PR#581](https://github.com/kafka4beam/brod/pull/581)

- 3.19.0
- Forward unhandled messages in topic/group consumer processes to handle_info/2 callbacks
in order to support arbitrary message passing [PR#580](https://github.com/kafka4beam/brod/pull/580)
Expand Down
2 changes: 1 addition & 1 deletion src/brod_client.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ get_partition_worker(ClientId, Key) when is_atom(ClientId) ->
%% If the worker process is returned form ets,
%% but it is not alive then there must be
%% an in-flight worker deregistration request.
case is_process_alive(Pid) of
case is_pid(Pid) andalso is_process_alive(Pid) of
true -> {ok, Pid};
false -> get_partition_worker_with_ets(ClientId, Key)
end;
Expand Down
Loading