Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for unknown_topic_cache_ttl option in brod_client #613

Merged
merged 7 commits into from
Dec 14, 2024

Conversation

mtvch
Copy link
Contributor

@mtvch mtvch commented Dec 3, 2024

Resolves #570

Copy link
Contributor

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
I added a few comments inline.
Please also help to update the changlog file.

src/brod_client.erl Outdated Show resolved Hide resolved
test/brod_client_SUITE.erl Outdated Show resolved Hide resolved
src/brod_client.erl Outdated Show resolved Hide resolved
src/brod_client.erl Outdated Show resolved Hide resolved
@mtvch mtvch requested a review from zmstone December 13, 2024 18:49
@zmstone zmstone merged commit 40a6ef6 into kafka4beam:master Dec 14, 2024
14 checks passed
@zmstone
Copy link
Contributor

zmstone commented Dec 14, 2024

Thank you @mtvch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why constant UNKNOWN_TOPIC_CACHE_EXPIRE_SECONDS (module brod_client) hard set 120 seconds?
2 participants