v1.0.8 (#52)

* v1.0.5 * v1.0.6 * v1.0.7 * fixed missing hitcount filter impl Co-authored-by: Oliver Kaiser <[email protected]>
kaisero · Aug 3, 2021 · a2009cc · a2009cc
1 parent 69bef1a
commit a2009cc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/fireREST/fmc/object/__init__.py b/fireREST/fmc/object/__init__.py
@@ -1,4 +1,4 @@
-from fireREST.fmc import Connection, Resource
+from fireREST.fmc import Connection
 from fireREST.fmc.object.anyprotocolportobject import AnyProtocolPortObject
 from fireREST.fmc.object.anyconnectcustomattribute import AnyconnectCustomAttribute
 from fireREST.fmc.object.anyconnectpackage import AnyconnectPackage

diff --git a/fireREST/fmc/policy/accesspolicy/operational/hitcounts/__init__.py b/fireREST/fmc/policy/accesspolicy/operational/hitcounts/__init__.py
@@ -8,7 +8,7 @@ class Hitcount(ChildResource):
     CONTAINER_NAME = 'AccessPolicy'
     CONTAINER_PATH = '/policy/accesspolicies/{uuid}'
     PATH = '/policy/accesspolicies/{container_uuid}/operational/hitcounts/{uuid}'
-    SUPPORTED_FILTERS = []
+    SUPPORTED_FILTERS = ['device_id', 'ids', 'fetch_zero_hitcount']
     SUPPORTED_PARAMS = []
     MINIMUM_VERSION_REQUIRED_GET = '6.4.0'
     MINIMUM_VERSION_REQUIRED_UPDATE = '6.4.0'
@@ -19,8 +19,8 @@ def update(self):
         return
 
     @utils.support_params
-    def get(self):
-        return
+    def get(self, container_uuid, device_id=None, ids=None, fetch_zero_hitcount=None, params=None):
+        return super().get(container_uuid, params=params)
 
     @utils.support_params
     def delete(self):

diff --git a/fireREST/mapping.py b/fireREST/mapping.py
@@ -230,6 +230,8 @@
     'original_destination_port': 'originalDestinationPort',
     'translated_source_port': 'translatedSourcePort',
     'translated_destination_port': 'translatedDestinationPort',
+    'ids': 'ids',
+    'fetch_zero_hitcount': 'fetchZeroHitCount',
 }
 
 PARAMS = {

diff --git a/fireREST/utils.py b/fireREST/utils.py
@@ -258,6 +258,7 @@ def search_filter(items=None):
         for item in items:
             for k, v in item.items():
                 if v:
+                    v = str(v).lower() if type(v) == bool else v
                     filter_str += f'{k}:{v};'
         return filter_str.rstrip(';')
     return ''