Fix some number of non-exhaustive warnings #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GreyCat, @generalmimon, another easy-to-review PR. Can lo please look? |
|
Another round of black magic... cast @GreyCat, cast @generalmimon, cast anyone with merge rights... |
Mingun
force-pushed
the
fix-warns
branch
4 times, most recently
from
7080082 to
aaf984a
Compare
Mingun
force-pushed
the
fix-warns
branch
2 times, most recently
from
c819c4f to
dd6a173
Compare
Mingun
force-pushed
the
fix-warns
branch
2 times, most recently
from
6ac1a52 to
2efab63
Compare
Mingun
force-pushed
the
fix-warns
branch
3 times, most recently
from
2acdd81 to
80d665f
Compare
Fixes 4 warnings:
```
[warn] /home/runner/work/kaitai_struct_compiler/kaitai_struct_compiler/compiler/shared/src/main/scala/io/kaitai/struct/datatype/BitEndianness.scala:29:123: match may not be exhaustive.
[warn] It would fail on the following input: Some((x: String forSome x not in ("be", "le")))
[warn] /home/runner/work/kaitai_struct_compiler/kaitai_struct_compiler/compiler/shared/src/main/scala/io/kaitai/struct/datatype/BitEndianness.scala:29:123: match may not be exhaustive.
[warn] It would fail on the following input: Some((x: String forSome x not in ("be", "le")))
[warn] def fromString(s: Option[String], defBitEndian: Option[BitEndianness], dt: String, path: List[String]): BitEndianness = s match {
[warn] ^
[warn] def fromString(s: Option[String], defBitEndian: Option[BitEndianness], dt: String, path: List[String]): BitEndianness = s match {
[warn] ^
[warn] /home/runner/work/kaitai_struct_compiler/kaitai_struct_compiler/compiler/shared/src/main/scala/io/kaitai/struct/datatype/Endianness.scala:57:127: match may not be exhaustive.
[warn] It would fail on the following input: Some((x: String forSome x not in ("be", "le")))
[warn] def fromString(s: Option[String], defaultEndian: Option[Endianness], dt: String, path: List[String]): Option[FixedEndian] = s match {
[warn] ^
[warn] /home/runner/work/kaitai_struct_compiler/kaitai_struct_compiler/compiler/shared/src/main/scala/io/kaitai/struct/datatype/Endianness.scala:57:127: match may not be exhaustive.
[warn] It would fail on the following input: Some((x: String forSome x not in ("be", "le")))
[warn] def fromString(s: Option[String], defaultEndian: Option[Endianness], dt: String, path: List[String]): Option[FixedEndian] = s match {
[warn] ^
```
Move `createSubstreamBuffered` from `EveryReadIsExpression` to `CommonReads` to make it available for `GoReads` I'm not sure that Borrowed types is possible there but types allow them. As a side effect, remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.