-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the QuickTime spec #684
base: master
Are you sure you want to change the base?
Conversation
I plan to extend it more, but I'd like to send out this chunk of work first, to check that I'm doing this right. Changes: 1) Updated URLs to Apple documentation. 2) Added docs 3) Implemented the matrix field 4) Added duration in seconds 5) Added two new atoms (there's a lot more in the spec) - Media header (mdhd) - Handler reference (hdlr)
Friendly ping. |
Thanks for the improvements, they look good to me. I don't fully understand the syntax in d8fce6b1fceb0695b1bb0106764e9d2927dd335c, though, but I guess it's all good. |
Most of it (the The |
I see, I was puzzled by for example Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small suggestions:
Co-authored-by: Petr Pučil <[email protected]>
Suggestions by: Petr Pučil <[email protected]>
Thanks for the suggestions, and the very detailed research! I updated the pull request, I hope I didn't miss any of your proposals. |
I plan to extend it more, but I'd like to send out this chunk of work first, to check that I'm doing this right.
Changes: