Fix temporary error when imports are used, support circular imports #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is marked as draft until kaitai-io/kaitai_struct_compiler#264 is merged and a new version of KSC is available at https://www.npmjs.com/package/kaitai-struct-compiler?activeTab=versions. Only then the exact version of |
Fixes #59 Fixes #159 - this is a particularly notable instance of the bug, since `TypeError: DosDatetime is not a constructor` is an error that initially everyone gets when they open the Web IDE in a fresh browser (this is because `zip.ksy` is selected by default, and it is affected by the bug since it contains an import). See kaitai-io/kaitai_struct#1074 and kaitai-io/kaitai_struct_compiler#264 - the actual fix was done in the KSC-generated JS code, which was changed to allow interdependent format modules to be loaded (and added to the global context in the case of the Web IDE) in any order. However, this was a backwards-incompatible change, so this set of Web IDE changes just updates our code to work with the new compiler.
generalmimon
force-pushed
the
fix-fresh-and-circular-imports
branch
from
1082485 to
12d4036
Compare
generalmimon
added a commit
to kaitai-io/kaitai-io.github.io
that referenced
this pull request
Feb 22, 2024
Related Web IDE pull requests with the changes: * kaitai-io/kaitai_struct_webide#170 * kaitai-io/kaitai_struct_webide#169 * kaitai-io/kaitai_struct_webide#166 * kaitai-io/kaitai_struct_webide#162 * kaitai-io/kaitai_struct_webide#163 * kaitai-io/kaitai_struct_webide#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Fixes #159 - this is a particularly notable instance of the bug, since
TypeError: DosDatetime is not a constructoris an error that initially everyone gets when they open the Web IDE in a fresh browser (this is becausezip.ksyis selected by default, and it is affected by the bug since it contains an import).See kaitai-io/kaitai_struct#1074 and kaitai-io/kaitai_struct_compiler#264 - the actual fix was done in the KSC-generated JS code, which was changed to allow interdependent format modules to be loaded (and added to the global context in the case of the Web IDE) in any order. However, this was a backwards-incompatible change, so this set of Web IDE changes just updates our code to work with the new compiler.