fix: falcon naming and cmd line params for download script

kaito-project · Oct 8, 2023 · 00a5db7 · 00a5db7
1 parent 41ad6eb
commit 00a5db7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml
@@ -170,7 +170,7 @@ jobs:
           --build-arg FALCON_MODEL_NAME=tiiuae/falcon-7b-instruct \
           .
   
-  falcon-13b:
+  falcon-40b:
     needs: setup
     runs-on: ubuntu-20.04
     if: ${{ needs.setup.outputs.FALCON_MODIFIED == 'true'}} 
@@ -197,13 +197,13 @@ jobs:
 
       - name: Build and push Falcon model
         run: |
-          az acr build -t aimodelsregistry.azurecr.io/falcon-13b:${{ needs.setup.outputs.image_tag }} \
+          az acr build -t aimodelsregistry.azurecr.io/falcon-40b:${{ needs.setup.outputs.image_tag }} \
           -r aimodelsregistry \
           -f docker/presets/falcon/Dockerfile \
-          --build-arg FALCON_MODEL_NAME=tiiuae/falcon-13b \
+          --build-arg FALCON_MODEL_NAME=tiiuae/falcon-40b \
           .
 
-  falcon-13b-instruct:
+  falcon-40b-instruct:
     needs: setup
     runs-on: ubuntu-20.04
     if: ${{ needs.setup.outputs.FALCON_MODIFIED == 'true'}} 
@@ -230,10 +230,10 @@ jobs:
 
       - name: Build and push Falcon model
         run: |
-          az acr build -t aimodelsregistry.azurecr.io/falcon-13b-instruct:${{ needs.setup.outputs.image_tag }} \
+          az acr build -t aimodelsregistry.azurecr.io/falcon-40b-instruct:${{ needs.setup.outputs.image_tag }} \
           -r aimodelsregistry \
           -f docker/presets/falcon/Dockerfile \
-          --build-arg FALCON_MODEL_NAME=tiiuae/falcon-13b-instruct \
+          --build-arg FALCON_MODEL_NAME=tiiuae/falcon-40b-instruct \
           .
 
   llama-2-7b:

diff --git a/docker/presets/download_script.go b/docker/presets/download_script.go
@@ -194,6 +194,9 @@ func main() {
 	token := ""
 	baseURL := ""
 	if linkType == PrivateLink {
+		if len(os.Args) != 4 {
+			log.Fatalf("Usage (private link): %s <link_type> <model_version> <external_IP> <external_port>", os.Args[0])
+		}
 		token = os.Getenv("AUTH_TOKEN_ENV_VAR")
 		if token == "" {
 			log.Fatal("AUTH_TOKEN_ENV_VAR not set!")