fix: aimodelsregistry ACR Push on Dispatch (#110)

This PR simplifies the ACR push process. Only if triggered by workflow dispatch do we push to registry `AIMODELSREGISTRY` with a tag specified by user In all other cases we push to `AIMODELSREGISTRYTEST` with this environment variable tag (e.g. 0.0.1) - this includes pushes to main and PR commits pulled against main. --------- Signed-off-by: Fei Guo <[email protected]> Co-authored-by: Fei Guo <[email protected]>
kaito-project · Oct 26, 2023 · 1815baa · 1815baa
1 parent 1d8a582
commit 1815baa
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/.github/workflows/preset-image-build.yml b/.github/workflows/preset-image-build.yml
@@ -17,10 +17,6 @@ on:
       - 'presets/llama-2-chat/**'
   workflow_dispatch:
     inputs:
-      release:
-        description: 'Release (yes/no)'
-        required: true
-        default: 'no'
       image_tag:
         description: 'Image Tag'
         required: true
@@ -29,6 +25,9 @@ permissions:
   id-token: write
   contents: read
 
+env:
+  VERSION: 0.0.1
+
 jobs:
   setup:
     runs-on: [self-hosted, username:runner-0]
@@ -97,12 +96,9 @@ jobs:
           if [[ "${{ github.event_name }}" == "workflow_dispatch" && -n "${{ github.event.inputs.image_tag }}" ]]; then
             echo "Using workflow dispatch to set image tag"
             echo "image_tag=${{ github.event.inputs.image_tag }}" >> $GITHUB_OUTPUT
-          elif [[ "${{ github.event_name }}" == "push" && "${{ github.ref }}" == "refs/heads/main" ]]; then
-            echo "Setting image tag to be latest"
-            echo "image_tag=latest" >> $GITHUB_OUTPUT
           else
-            echo "Setting image tag based on latest commit"
-            echo "image_tag=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+            echo "Setting image tag based on version set"
+            echo "image_tag=${{ env.VERSION }}" >> $GITHUB_OUTPUT
           fi
 
       - name: Print Image Tag
@@ -179,7 +175,7 @@ jobs:
       - name: 'Attach and Login to ACR'
         id: acr_login
         run: |
-          if [[ "${{ needs.setup.outputs.image_tag }}" == "latest" ]]; then
+          if [[ "${{ github.event_name }}" == "workflow_dispatch" && -n "${{ github.event.inputs.image_tag }}" ]]; then
             ACR_NAME="aimodelsregistry"
           else
             ACR_NAME="aimodelsregistrytest"