fix: check private and remove validation check

kaito-project · Oct 25, 2023 · e9ef63e · e9ef63e
1 parent 1552eb6
commit e9ef63e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/api/v1alpha1/workspace_validation.go b/api/v1alpha1/workspace_validation.go
@@ -85,9 +85,5 @@ func (i *InferenceSpec) validateUpdate(old *InferenceSpec) (errs *apis.FieldErro
 		errs = errs.Also(apis.ErrGeneric("field cannot be unset/set if it was set/unset", "template"))
 	}
 
-	if i.Preset.PresetMeta.AccessMode == "private" && i.Preset.PresetOptions.Image == "" {
-		errs = errs.Also(apis.ErrGeneric("When AccessMode is private, an image must be provided in PresetOptions").ViaField("presetOptions"))
-	}
-
 	return errs
 }
diff --git a/pkg/controllers/workspace_controller.go b/pkg/controllers/workspace_controller.go
@@ -434,7 +434,7 @@ func (c *WorkspaceReconciler) getInferenceObjFromPreset(ctx context.Context, wOb
 	}
 
 	inferenceObj.AccessMode = string(wObj.Inference.Preset.PresetMeta.AccessMode)
-	if wObj.Inference.Preset.PresetOptions.Image != "" {
+	if inferenceObj.AccessMode == "private" && wObj.Inference.Preset.PresetOptions.Image != "" {
 		inferenceObj.Image = wObj.Inference.Preset.PresetOptions.Image
 
 		imagePullSecretRefs := []corev1.LocalObjectReference{}